deprecate_disable: support optional replacement parameter #18733
+183
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Addresses #18294.
A replacement may be specified like so:
which yields something like
and, for disabled:
which yields something like
brew install
help text. Note that there is no distinction between the string argument as a formula or cask; there is no validation on the value of the string.deprecate!
reason whendisable!
exists #18661 is open and this may need to be refactored after that is merged (or vice versa).